-
Notifications
You must be signed in to change notification settings - Fork 397
fix(core): toolsType is overridden when install multiple solutions #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): toolsType is overridden when install multiple solutions #3717
Conversation
🦋 Changeset detectedLatest commit: beeb404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 207 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
==========================================
+ Coverage 57.59% 58.12% +0.52%
==========================================
Files 672 643 -29
Lines 17794 17181 -613
Branches 3876 3757 -119
==========================================
- Hits 10249 9986 -263
+ Misses 6934 6593 -341
+ Partials 611 602 -9 ☔ View full report in Codecov by Sentry. |
Summary
If we use the
bin/modern.js
to settoolsType
, thetoolsType
might be overridden if we have multiple solutions installed.So we should set the
toolsType
when a solution plugin is registered and executed.🤖 Generated by Copilot at 5ce74a3
This pull request removes the unused
toolsType
feature from the core package and allows each solution to set its owntoolsType
in the app context. This fixes a bug wheretoolsType
was overridden when installing multiple solutions and updates the changeset and tests accordingly.Details
🤖 Generated by Copilot at 5ce74a3
Related Issue
Checklist
pnpm run change
.