Skip to content

Conversation

tsmith023
Copy link
Collaborator

@tsmith023 tsmith023 commented Apr 28, 2025

Closes #1654

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 87.08861% with 51 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev/1.32@a6a4254). Learn more about missing BASE report.

Files with missing lines Patch % Lines
weaviate/collections/classes/config_vectors.py 77.12% 35 Missing ⚠️
weaviate/collections/classes/config.py 90.00% 4 Missing ⚠️
...eaviate/collections/classes/config_vector_index.py 96.80% 4 Missing ⚠️
weaviate/warnings.py 80.00% 3 Missing ⚠️
integration/test_collection.py 84.61% 2 Missing ⚠️
integration/test_vectors.py 50.00% 2 Missing ⚠️
weaviate/collections/config/executor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/1.32    #1659   +/-   ##
===========================================
  Coverage            ?   87.09%           
===========================================
  Files               ?      269           
  Lines               ?    18614           
  Branches            ?        0           
===========================================
  Hits                ?    16211           
  Misses              ?     2403           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmith023 tsmith023 requested a review from dirkkul April 28, 2025 09:55
@tsmith023 tsmith023 marked this pull request as ready for review April 28, 2025 09:55
@tsmith023 tsmith023 requested a review from a team as a code owner April 28, 2025 09:55
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

…ient into vectors/deprecate-legacy-introduce-named-vectors-only-syntax
- Allow `quantizer` at root of all `Vectors` and `MultiVectors` methods
- Allow `encoding` also at root of all `MultiVectors` methods
- Add `multi_vector_config` arg to `MultiVectors` methods
- Add deprs warnings if `multi_vector`
- Update tests to use new syntax
@tsmith023 tsmith023 changed the base branch from main to dev/1.32 June 30, 2025 14:37
…n-client into vectors/deprecate-legacy-introduce-named-vectors-only-syntax
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@tsmith023 tsmith023 merged commit f8d7d2d into dev/1.32 Jul 10, 2025
53 of 54 checks passed
@tsmith023 tsmith023 deleted the vectors/deprecate-legacy-introduce-named-vectors-only-syntax branch July 10, 2025 14:30
tsmith023 added a commit that referenced this pull request Jul 10, 2025
* Implement `client.replication` namespace for all replicate ops

* Remove default kwargs from executor

* Remove `TypedDict` classes mapping to API responses

* Add include history true default to list all method

* Add `shard` option to `cluster.nodes()` method

* Allow `query_sharding_state` to return `None` if collection/shard doesn't exist

* Fix stubs for `list_all()` and `query()`

* Fix `resp_rest` in `tenants.get_by_name`

* Simplify `cluster.nodes()` output types

* Add support for RQ

Add Rotational quantization (RQ) support in the client to configure
collections using that quantization technique

* Add coverage for RQ

* Fix ruff linter

* Fix comment

* ci: Add Weaviate 1.32 version pointing to main

Preliminary commit. Update once stable v1.32 exists

* ci: Enable run in 1.32

* Add RBAC permissions for replicate operations

* Run `stubs_regen.sh`

* Add `REPLICA_MOVEMENT_ENABLED: 'true'` to env var in ci

* Skip replicate tests in <1.31.0

* Move all replicate ops under the cluster namespace

* Skip replicate tests in <1.31.0

* Only test RBAC replicate with >1.31.0

* Ensure no test collisions using xdist and cleanup of repl ops

* update weaviate version for 1.32

* Update to use latest API on `stable/v1.32` and forbid tests in <1.32.0

* Make types for `ReplicateOperation` with/without history

* Add missing `ReplicateOperations` to `weaviate.outputs`

* Ensure list is always returned for `status.errors`

* Add `ShardingState` and `ShardReplicas` to `weaviate.outputs`

* Fix name of `targetNode` param in query by target node

* Add weaviate aliases

* Add support for alias actions

* Add support for alias

* Fix test and update to latest version in CI

* Skip tests on lower version

* Fix min version in rbac test

* Add min version to all tests

* Fix parametrization

* Disable vectorizer for alias test

* None in more tests

* Fix alias names in concurrent tests

* Prefix alias names with alias

* Fix more concurrency issues

* Fix type hint

* Fix test with concurrent tests

* Fix test

* Remove duplicated test

* Remove missed docstring from `WeaviateAsyncClient`

* chore: Fix the version check for alias to v1.32

Signed-off-by: Kaviraj <[email protected]>

* Vectors/deprecate legacy introduce named vectors only syntax (#1659)

* Introduce `Configure.Vectors` and `vector_config` in `.create`/`.update`

* Update CI images to latest build on each branch

* Change prop descr test to handle props sorted by name

* Make changes to pass unit tests of legacy vectorization

* Alter specific tests for old versions with new syntax

* Add skip to test with resolved issue absent from previous vers

* - Add `MultiVectors` factory
- Allow `quantizer` at root of all `Vectors` and `MultiVectors` methods
- Allow `encoding` also at root of all `MultiVectors` methods

* Update CI tags to latest patch

* Rename `.text2colbert_jinaa()` to `text2vec_jinaai()`

* Add warnings for all deprecated syntax

* Response to review comments
- Add `multi_vector_config` arg to `MultiVectors` methods
- Add deprs warnings if `multi_vector`
- Update tests to use new syntax

* Update tests to reflect single vectors usage

* Fix vector config name passing when creating collections

* Skip parsing vector to obj if it's empty

* Update CI images to latest patches

* Remove unneeded added parsing

* Add changelog for 4.16.0

---------

Signed-off-by: Kaviraj <[email protected]>
Co-authored-by: Rodrigo Lopez <[email protected]>
Co-authored-by: Roberto Esposito <[email protected]>
Co-authored-by: Roberto Esposito <[email protected]>
Co-authored-by: Dirk Kulawiak <[email protected]>
Co-authored-by: Dirk Kulawiak <[email protected]>
Co-authored-by: Kaviraj <[email protected]>
rlmanrique added a commit that referenced this pull request Jul 11, 2025
@tsmith023 tsmith023 restored the vectors/deprecate-legacy-introduce-named-vectors-only-syntax branch July 11, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor collection creation to prefer named vectors

5 participants