Standardize the sync/suspend/edit buttons

[opudrovs]

Closes #3374

• Replaced custom sync/suspend controls with the new SyncControls component.
• Replaced the icon EditButton with a text-based EditButton with the new Settings icon.
• Updated the snapshots.
• Fixed related tests.

Notes:

• The current PR is an enterprise counterpart to:
  Standardize the sync/suspend/edit buttons weave-gitops#4080
• Syncing a TF object never works for me locally, but I observed this issue before the current changes.

[opudrovs]

Put on hold until Thursday because of failing tests (breaking changes in OSS).

[enekofb]

i could click on edit gitopsset from template. the request is executed with 500

{
    "code": 2,
    "message": "looking up objects of kind GitOpsSet not supported",
    "details": []
}

[opudrovs]

I see, in this case maybe editing GitOpsSet objects is not supported on the backend? Because I only added the edit button on the frontend (if I got the ticket requirements right).

Maybe we need to move adding Edit button to GitOpsSets to a separate ticket? I thought the backend part is finished already.

[opudrovs]

The backend error message is from core/server/primarykinds.go in OSS:

// Lookup ensures that a kind name is known, white-listed, and returns
// the full GVK for that kind
func (pk *PrimaryKinds) Lookup(kind string) (*schema.GroupVersionKind, error) {
	gvk, ok := pk.kinds[kind]
	if !ok {
		return nil, fmt.Errorf("looking up objects of kind %v not supported", kind)
	}

	return &gvk, nil
}

[opudrovs]

The frontend error message visible on the screenshot is from a frontend check for template name in annotations:

const templateName = getCreateRequestAnnotation(resource)?.template_name;
if (!templateName) {
...
[show notification with text]
No edit information is available for this resource.
...

[opudrovs]

I am not sure how a GitOpsSet is created from a template and if the template name should be added automatically or manually. Maybe this functionality should be added too.

[enekofb]

In the terraform table page i could see controls but sync hangs

I dont see sync controls in terraform within the details page

[opudrovs]

I dont see sync controls in terraform within the details page

Weird, they should be there. They are rendered non-conditionally.

[opudrovs]

Have you pulled in the latest commit? Because I think I removed Sync controls on the TF object details page temporarily on rebase and re-added them later.

[opudrovs]

In the terraform table page i could see controls but sync hangs

TF object sync always hangs for me even locally in the main branch, I have not changed any sync logic.

There was an old issue for it with sync timing out:
#2264
but it looks like it was fixed.

[opudrovs]

Here are the new controls I can see in the TF object details page in the current branch:

Where else you cannot see the new controls?

[enekofb]

checking again, i was able to see the new controls in the other but terrraform UIs

[opudrovs]

@enekofb weird, must be a caching issue (Tilt, yarn or browser), because I see them in the app, they are replaced in the code on TerraformObjectDetail view, and TerraformObjectDetail view tests are updated with the test IDs from the new controls.

Could you delete the node_modules folder and run make node_modules? And possibly restart everything (native-ui-build, compile, clusters-service, whatever is relevant) in Tilt manually and re-test?

I think I had a similar issue with UI not updating in the past once or twice.

@jpellizzari @joshri could any of you please check that the new Sync/Suspend controls are present on the Terraform object details view?

[opudrovs]

@enekofb @jpellizzari @joshri as discussed with @LappleApple , I removed the Edit GitOpsSet functionality (it might be added in another issue later), so the current PR can be reviewed.

[opudrovs]

Integration tests are failing twice, restarting them.

[jpellizzari]

LGTM 👍