Skip to content

fix listeners re-adding with share buttons update (2) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2021
Merged

fix listeners re-adding with share buttons update (2) #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae9dbd9
fix listeners re-adding with share buttons update
tnga Sep 5, 2021
9c56e85
better code logic with fix on listeners update
tnga Sep 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 42 additions & 3 deletions src/share-buttons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
var prepareLink = function (el, options) {
options.id = getAttribute(el, 'data-id');
if (options.id) {
removeEventListener(el, 'click');
addEventListener(el, 'click', options);
}
};
Expand Down Expand Up @@ -135,6 +136,34 @@
return getAttribute(share, 'data-desc') || (metaDesc && getAttribute(metaDesc, 'content')) || ' ';
};

/**
* Counter for generated cache's share button's index.
* This to reference added share buttons' listeners.
*/
var refCounter = 0
/**
* List of added listeners' for share buttons.
* This to index listeners' for update or removal purpose.
*/
var listenersCache = {}

/**
* Method for detaching event to the element
* @param {HTMLElement} el
* @param {string} eventName
*/
var removeEventListener = function (el, eventName) {
var cachedRef = el.getAttribute('data-sharebtn-ref');

if (cachedRef) {
if (el.removeEventListener) {
el.removeEventListener(eventName, listenersCache[cachedRef]);
} else {
el.detachEvent('on' + eventName, listenersCache[cachedRef+'ie']);
}
}
};

/**
* Method for attaching event to the element
* @param {HTMLElement} el
Expand All @@ -145,13 +174,23 @@
var handler = function () {
share(opt.id, opt.url, opt.title, opt.desc);
};
var iehandler = function () {
handler.call(el);
};
var cachedRef = el.getAttribute('data-sharebtn-ref');

if (!cachedRef) {
cachedRef = ++refCounter;
el.setAttribute('data-sharebtn-ref', cachedRef);
}

listenersCache[cachedRef] = handler;
listenersCache[cachedRef+'ie'] = iehandler;

if (el.addEventListener) {
el.addEventListener(eventName, handler);
} else {
el.attachEvent('on' + eventName, function () {
handler.call(el);
});
el.attachEvent('on' + eventName, iehandler);
}
};

Expand Down