THE BIG CLI REWRITE #94

jakelang · 2019-05-27T23:08:39Z

WE ARE A MODERN INDEPENDENT SOFTWARE PROJECT SO LETS HAVE THE UI OF ONE

axic · 2019-07-15T23:58:17Z

@jakelang is this going to be finished?

chisel/src/result.rs

axic · 2019-09-19T20:03:20Z

chisel/src/main.rs

                .global(true),
        )
+        .arg(
+            Arg::with_name("DEBUG_MESSAGES")


Why not keep VERBOSE as before?

Looks strange when you run chisel --help

chisel/src/options.rs

chisel/src/result.rs

chisel/src/driver.rs

axic · 2019-09-19T21:25:07Z

chisel/src/driver.rs

+            while let Some((name, module)) = ruleset.modules_mut().pop_front() {
+                chisel_debug!(1, "Executing module {}", &name);
+
+                // TODO: homogeneous module handling


I think the solution to this giant mess is passing a HashMap<String, String> as configuration as part of ChiselModule or ModulePreset.

Attempted it in #161.

axic · 2019-09-25T15:08:05Z

chisel/src/result.rs

    /// Returns Ok(false) if there is no mutation.
    /// Returns error on writer error or invalid mode.
-    pub fn write(&mut self, mode: &str) -> Result<bool, Box<dyn Error>> {
+    pub fn write(mut self, mode: &str) -> Result<bool, Box<dyn Error>> {


axic · 2019-09-25T22:57:49Z

chisel/src/main.rs

-    fn fields(&self) -> (&String, &String) {
-        (&self.module_name, &self.preset)
-    }
+fn fail(code: i32, message: &str) -> ! {


Looking at all the users of fail, all of them use code = 1. Do we need the code right now?

jakelang · 2019-12-28T23:36:21Z

Split into different PRs and merged.

jakelang added the enhancement New feature or request label May 27, 2019

jakelang force-pushed the refactor-cli branch 2 times, most recently from e6622ad to 649fd3b Compare June 8, 2019 15:48

jakelang changed the title ~~Refactor CLI~~ CLI Refactor Part 1 Jun 11, 2019

jakelang changed the base branch from master to cli-refactor-staging June 11, 2019 17:23

jakelang added the wip label Jun 20, 2019

jakelang force-pushed the refactor-cli branch from ea20fc7 to 43f4555 Compare June 23, 2019 18:35

jakelang force-pushed the refactor-cli branch 2 times, most recently from 0a39862 to c6b65c3 Compare July 31, 2019 22:02

jakelang changed the title ~~CLI Refactor Part 1~~ THE BIG CLI REWRITE Aug 2, 2019

jakelang added the monster Huge PR. What hath thou wrought label Aug 2, 2019

jakelang force-pushed the refactor-cli branch 3 times, most recently from 56f3af8 to 14c7a33 Compare August 7, 2019 20:14

jakelang force-pushed the refactor-cli branch from 76ab059 to 19b0b12 Compare August 23, 2019 20:54

axic changed the base branch from cli-refactor-staging to master August 29, 2019 22:23

axic force-pushed the refactor-cli branch 4 times, most recently from 39d72fa to 5fc46be Compare September 8, 2019 11:56

jakelang mentioned this pull request Sep 19, 2019

CLI: Introduce new config infrastructure #158

Merged

jakelang force-pushed the refactor-cli branch from 159a81b to e84387b Compare September 19, 2019 18:34