Skip to content

Conversation

attilaolah
Copy link

Potential workaround for #778, should double-check though before merging.

@attilaolah attilaolah changed the title chore(deps): bump pyo3 requirement from 0.14 to 0.19 in all packages chore(deps): bump pyo3 requirement from 0.14 to 0.16 Sep 9, 2025
@reneleonhardt
Copy link

reneleonhardt commented Sep 9, 2025

No pull request has been accepted since 2023, so everything is even more outdated now naturally than 2 years ago.

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2

actions/upload-artifact@v4 is the latest major release.

@attilaolah
Copy link
Author

Yeah, and the latest version is v4, and ther's been some breaking changes between v3 and v4 so I'll try to bump it to v3 for now.

@reneleonhardt
Copy link

My script shows

GitHub Actions Updates:
Swatinem/[email protected]
actions/[email protected]
actions/[email protected]
actions/[email protected]
actions/[email protected]

@attilaolah
Copy link
Author

Thanks. The upload-artifacts one indeed needs v4. I'll attempt but there's been some change in the naming uf the uploaded artifacts so we'll see.

@reneleonhardt
Copy link

Good luck with that 😉

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@reneleonhardt
Copy link

reneleonhardt commented Sep 9, 2025

Yeah, but the naming only affects literally the same name (arm64 and amd64 producing the file foo instead of foo-arm64 and foo-amd64).

@reneleonhardt
Copy link

noble bumped libtinfo5 to libtinfo6

@attilaolah
Copy link
Author

Yep I see what I did now, I pulled a string and this is what came out 😃

@attilaolah
Copy link
Author

I have exactly 6 more minutes to spend on this so I might have to revisit this later.

@reneleonhardt
Copy link

reneleonhardt commented Sep 9, 2025

actions/setup-python@v6 is extremely breaking, maybe v5 works better.
Don't know why Python 3.7 and 3.8 need to be supported if upstream doesn't support them anymore... and 3.14 around the corner 🤷

@attilaolah
Copy link
Author

LLVM 13 is also quite old now, maybe a gentle bump there would work too.

I'll try setup-python v5 for now, but I'd be for dropping Python anything less than 3.10, as a proposal. 3.14 is upon us.

@attilaolah attilaolah mentioned this pull request Sep 9, 2025
@reneleonhardt
Copy link

As I said, literally everything is extremely outdated here after years without maintenance of course, it's a wonder that CI even runs 😄

ubuntu needs:

sudo apt-get install libtinfo6

macos needs:

brew install gettext
brew link gettext --force

@attilaolah
Copy link
Author

Branched off the CI-only changes to #781, but for now I have to run.

Thanks for checking in :)

@reneleonhardt
Copy link

ubuntu:24.04 defaults to LLVM 18:
https://documentation.ubuntu.com/ubuntu-for-developers/reference/availability/llvm/

Maybe a more gentle upgrade would be more successful, ubuntu:22.04 and LLVM 14.

@attilaolah attilaolah marked this pull request as draft September 9, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants