Add more fallible font methods #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorporeal
approved these changes
Dec 23, 2025
vorporeal
left a comment
vorporeal
left a comment
There was a problem hiding this comment.
approving because it's fine as is, and want to unblock, but worth thinking about whether we actually want to retain the versions that can panic, or if we should fully replace them with fallible versions and force ourselves to update all calling code appropriately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is to fix this crash: https://warpdotdev.sentry.io/issues/7090816280
This work follows up on some fixes I've been doing upstream: servo#62
However, this thread of work has some unmerged stuff that is breaking and may take more effort to merge upstream: servo#64
This PR brings some more fixes into our own fork.