feat(action): adds flag to optionally fail on errors #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linked with issue #687 |
|
@wagoid I added a couple tests and some docs, let me know if this needs anything else! |
wagoid
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Awesome work @cmitzel-ncino! Could you also add this param to action.yml file? Like here
wagoid
approved these changes
Apr 10, 2023
|
Merging it, thanks @cmitzel-ncino! |
|
Hitting an issue with the action reporting Looking at the docs I believe I'm missing an argument for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, trying to implement a flag to the action such that the action will result in a success status regardless of errors or warnings.
I need to implement one or two tests still, I'm pretty new to developing in TS outside of the AWS CDK so taking my time to learn.