Skip to content

Conversation

twiss
Copy link
Member

@twiss twiss commented Feb 28, 2022

Use |variable_name| instead of <var> elements, and backticks (`) instead of <code> elements.

Also, place the quotes in string literals outside the monotext formatted string value.


💥 Error: connect ETIMEDOUT 128.30.52.89:443 💥

PR Preview failed to build. (Last tried on Feb 28, 2022, 7:06 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Also, place the quotes in string literals outside the monotext
formatted string value.
@twiss twiss requested a review from annevk February 28, 2022 18:41
@twiss twiss changed the title Use backticks (`) instead of <code> elements Use shorthand forms instead of <var> and <code> elements Feb 28, 2022
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp, so you might want to get another reviewer with more available time for this. I skimmed through the first commit a bit and it seems fine. GitHub UI wouldn't let me load the second commit.

@twiss
Copy link
Member Author

twiss commented Mar 1, 2022

Thanks! I'll go ahead and merge, as I'm not sure anyone wants to read this entire diff and I don't think it's particularly worth doing anyway (if you've seen one line of diff you've more or less seen them all 😅)

@twiss twiss merged commit 63c53ef into main Mar 1, 2022
@twiss twiss deleted the code-backticks branch March 1, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants