Skip to content

Conversation

antosart
Copy link
Member

No description provided.

@antosart
Copy link
Member Author

@mikewest this was suggested in this comment and makes sense to me.

Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sounds like a reasonable change (and we don't handle null well in the spec generally, so picking a directive is a good thing).

::
1. Return null.

4. Return `connect-src`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a note here that this is intended to be a default fallback for new fetch destinations that are added which don't explicitly fall into one of the other categories?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, done.

@antosart antosart force-pushed the change-fallback-fetch-dest branch from 2ff832b to 96a9a3c Compare July 27, 2023 08:49
@antosart antosart merged commit e785cd1 into main Jul 27, 2023
@antosart antosart deleted the change-fallback-fetch-dest branch July 27, 2023 08:51
github-actions bot added a commit that referenced this pull request Jul 27, 2023
SHA: e785cd1
Reason: push, by antosart

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants