Skip to content

draft 2 wip #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 23, 2021
Merged

draft 2 wip #52

merged 7 commits into from
Sep 23, 2021

Conversation

decentralgabe
Copy link
Collaborator

No description provided.

OR13
OR13 reviewed Sep 17, 2021
View reviewed changes
OR13
OR13 reviewed Sep 17, 2021
View reviewed changes
OR13
OR13 reviewed Sep 17, 2021
View reviewed changes
@decentralgabe decentralgabe marked this pull request as ready for review September 21, 2021 22:20
@decentralgabe
Copy link
Collaborator Author

@OR13 I have updated a good amount of language and examples in the specification.
I have not yet included a schema for the entire credential. I need to think how to best specify which piece(s) of a credential a schema applies to - I'd like to take that in a follow up PR. Let me know what you think about this cut.

Perhaps it's best to create a v2 branch and push to there instead of master?

This was referenced Sep 21, 2021
Closed
Closed
@decentralgabe decentralgabe merged commit 1f664d3 into master Sep 23, 2021
@decentralgabe decentralgabe deleted the v2-draft branch September 23, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decentralgabe @OR13