Skip to content

Status of this repository? #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awoie opened this issue Aug 31, 2021 · 5 comments
Closed

Status of this repository? #51

awoie opened this issue Aug 31, 2021 · 5 comments
Assignees

Comments

@awoie
Copy link

awoie commented Aug 31, 2021

  • is this still active?
  • is there a latest rendered draft for JSON schema validation publish?
  • why is the JSON schema validation only applied to the credentialSubject rather than the top-level VC object--note, one could extend the top-level VC object as well.
@decentralgabe
Copy link
Collaborator

It is in need of a new owner.

@tmarkovski
Copy link

  • is there a latest rendered draft for JSON schema validation publish?

https://w3c-ccg.github.io/vc-json-schemas/

  • why is the JSON schema validation only applied to the credentialSubject rather than the top-level VC object--note, one could extend the top-level VC object as well.

I'm curious about this, too. A top level schema would make more sense, as it doesn't restrict the VC validation only to credentialSubject, which is valid under the VC recommendation.
It's also unclear from the VC spec if the credentialSchema field refers to the top level VC schema or the credentialSubject only. This spec makes it clear it's the credentialSubject only, though not sure if this is just an interpretation.

Pinging @OR13

@decentralgabe decentralgabe self-assigned this Sep 6, 2021
@decentralgabe
Copy link
Collaborator

I will work with Orie to get this updated.

My main goals:

  1. Adopt the latest version of JSON Schema
  2. Apply validation to the entire VC optionally

My thinking there is you really care about the data shape of the credentialSubject independently of the entire VC. Two schemas are necessary, and this is actually a practice we already adopted at Workday -- https://github.com/workdaycredentials/ledger-common/blob/master/credential/schema/verifiable-credential-schema.json

@decentralgabe
Copy link
Collaborator

Work happening here, PTAL #52

@decentralgabe
Copy link
Collaborator

Closing as Draft 2, a work in progress has been published. Please open additional issues with specific requested improvements. Of course, PRs are welcome too!

https://w3c-ccg.github.io/vc-json-schemas/v2/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants