-
Notifications
You must be signed in to change notification settings - Fork 118
Clarify schema #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The issue was discussed in a meeting on 2021-09-08
View the transcript4.3. Clarify schema (issue vc-data-model#812)See github issue #812. David Chadwick: I hope it's v1.1. But I'd like feedback from the group, Brent Zundel: I guess it comes down to, do you feel this issue is resolvable with editorial changes? David Chadwick: Yes, I think it is... there's an issue I can point to, here...
David Chadwick: I'm not participating in this work, but watching... Dave Longley: My thought has always been that it applies to the entire VC. People can add properties in other places in a VC and would want to use a schema that way. David Chadwick: That was my understanding... just wanted to tighten the wording so it's 100% clear Brent Zundel: I agree with that interpretation, and that PR that resolves it would be appropriate for v1.1 |
Can those (elsewhere) discussions be linked from here? Understanding how existing text is being (mis-)interpreted is likely to help guide rewording to better clarity. |
Quote from w3c/vc-json-schema#51 (comment) "It's also unclear from the VC spec if the credentialSchema field refers to the top level VC schema or the credentialSubject only. This spec makes it clear it's the credentialSubject only, though not sure if this is just an interpretation." This is why it is important for the VC spec to make it crystal clear that credentialSchema refers to the top level VC schema |
PR #816 has been raised to resolve this issue. |
We are waiting on merge conflicts to be resolved in PR #816 to merge it into v1.1. |
I believe the merge conflicts are only on the README.md and not on the standard itself. Please correct me if I am wrong. If I am correct I have tried to fix this, but should I have failed, I would appreciate you helping me out on this. Kind regards. David |
The PR in #816 has been cleaned up now to address this issue and has been merged now after multiple positive reviews and all necessary feedback addressed. Closing this issue. Thanks for your help in raising and fixing this issue @David-Chadwick |
The issue was discussed in a meeting on 2021-10-27
View the transcript2.11. Clarify schema (issue vc-data-model#812)See github issue vc-data-model#812. Brent Zundel: David says here in the thread that it is address in 816, which is open.... Manu Sporny: what's going on here? seems ready, but merge conflicts. Brent Zundel: I'll just assign David and see if this can get done before 1.1. |
Adding the Editorial label here so that it properly gets detected as an editorial errata by the errata file |
There has been some discussions (elsewhere) about precisely what the schema property should contain i.e. whether it is for the entire VC or VP, or only for the subject properties of the VC. I think the WG should be very clear about this and ensure that the text makes it crystal clear.
The text was updated successfully, but these errors were encountered: