Conformance testing #229
Conformance testing #229
Conversation
- accessible escape room - govuk testing
trying to stop git corrupting the .mp4 video file.
- captions are in a .vtt file. - [NASA video source URL](https://images.nasa.gov/details-One%20Small%20Step.html). - captions are unstyled, but there is a commented-out `::cue` selector in the “silver-breaking-things-for-testing.css” file if need’s be.
There was a problem hiding this comment.
I've taken a look at this a couple times but can't give a meaningful review. 573 files is a lot to add, and it is impractical for me to vet them all for security issues and side effects. If the entire addition is under prototypes/conformance-testing maybe it's ok, though security especially XSS looks like a potential worry. I can't evaluate this well on the web site, and I can't check the branch out to check locally because I get a notice that there are invalid files:
error: invalid path 'prototypes/conformance-testing/govuk/tests/colour-and-contrast-large-text-does-not-have-a-contrast-ratio-of-at-least-45:1-so-does-not-meet-aaa.html'
error: invalid path 'prototypes/conformance-testing/govuk/tests/colour-and-contrast-small-text-does-not-have-a-contrast-ratio-of-at-least-45:1-so-does-not-meet-aa.html'
This suggests there is at least one problem that needs fixing - I'd sure hate to merge this into master and then get this error message on the master branch, rendering the repository unusable. At this moment I can't give affirmative approval to the rest of the content, though I'm not explicitly disapproving it either.
|
Hey, Michael. Thanks for the note. What we've done is to take the conformance testing experiments and host them as GitHub Pages repos here:
If we do it like this, it'll reduce the burden on you and the tools are still out in the open for people to fork, etc. |
3 participants
This is the test pages and an index page with links to the tools we are using for Conformance Testing. It would be helpful to merge it so we can use a more permanent link.