Skip to content

Improve description of keyword aliases using @protected #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Sep 27, 2019

and add more to the grammar.

For #246.


Preview | Diff

@gkellogg gkellogg merged commit 99288f7 into master Sep 28, 2019
@gkellogg gkellogg deleted the protected-keywords branch September 28, 2019 17:36
@@ -12050,9 +12057,14 @@ <h2>Context Definitions</h2>
<code>@container</code>,
<code class="changed">@context</code>,
<code class="changed">@prefix</code>,
<code class="changed">@propagate</code>, or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did remove @propagate from this list earlier (b4dae4d), because I don't see anything the API where it is expected in an expanded term definition...

Am I missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I you’re right, only a context definition can contain @propagate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I you’re right, only a context definition can contain @propagate.

@@ -12110,13 +12122,21 @@ <h2>Context Definitions</h2>
<p class="changed">If an <a>expanded term definition</a> has an <code>@context</code> <a>entry</a>,
it MUST be a valid <code>context definition</code>.</p>

<p class="changed">If a <a>context</a> contains the <code>@import</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole paragraph is a copy of the one line 12017... Was the intent to replace "context" by "expanded term definition"?? That would be strange as @import can not appear in an expanded term definition...

<p class="changed">If the <a>expanded term definition</a> contains the <code>@nest</code>
<a>keyword</a>, its value MUST be either <code>@nest</code>, or a term
which expands to <code>@nest</code>.</p>

<p class="changed">If the <a>expanded term definition</a> contains the <code>@prefix</code>
<a>keyword</a>, its value MUST be <code>true</code> or <code>false</code>.</p>

<p class="changed">If the <a>expanded term definition</a> contains the <code>@propagate</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf. my comment above, I don't think that an expanded term definition can contain the @propagate keyword...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants