Skip to content

Improve fix to #241 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Improve fix to #241 #266

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da6d079
fixed wrong wording
pchampin Dec 20, 2019
86e99e4
instead of "skip following substeps", include `null` test in step 16
pchampin Dec 20, 2019
1bb3603
Remove prior entry in changes since cr.
gkellogg Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,14 +1616,12 @@ <h3>Algorithm</h3>
</li>
<li>Set the <a>reverse property</a> flag of <var>definition</var>
to <code>false</code>.</li>
<li>If <var>value</var> contains the <a>entry</a> <code>@id</code> and its value
does not equal <var>term</var>:
<li class="changed">If <var>value</var> contains the <a>entry</a> <code>@id</code> and its value
neither equals <var>term</var> nor is <code>null</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should end with a ":"? Otherwise it runs into the inline "note" below. It'll look odd either way.

Related is that all the other inline "notes" also look odd compared to the full "NOTE" blocks. Were they supposed to be inline?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReSpec supports both, and sometimes it makes sense to do. Full block notes are pretty heavyweight.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs something done. It reads "... nor is null If null, the term ...". The inline note style is there for the "If null...", but the final rendered result could be improved.

<span id="ctd-id-null" class="note">If `null`, the term is not used for IRI expansion, but is
retained to be able to detect future redefinitions of this term.</span>:
<ol>
<li id="ctd-id-null" class="changed">If <var>value</var> contains the <code>@id</code> <a>entry</a>
is <code>null</code>, the term is not used for IRI expansion, but is
retained to be able to detect future redefinitions of this term
and the following sub-steps are skipped.</li>
<li>Otherwise, if the value associated with the <code>@id</code> <a>entry</a> is not a <a>string</a>, an
<li>If the value associated with the <code>@id</code> <a>entry</a> is not a <a>string</a>, an
<a data-link-for="JsonLdErrorCode">invalid IRI mapping</a>
error has been detected and processing is aborted.</li>
<li>If the value associated with the `@id` <a>entry</a>
Expand Down Expand Up @@ -6901,9 +6899,9 @@ <h4>JsonLdErrorCode</h4>
<section class="appendix informative" id="changes-from-cr">
<h2>Changes since Candidate Release of 12 December 2019</h2>
<ul>
<li>Clarified step <a href="#ctd-id-null">16.1</a> of the
<a href="#create-term-definition">Create Term Definition algorithm</a>
that remaining steps are skipped if the value of `@id` is `null`.
<li>Merged <a href="#ctd-id-null">the former substep 16.1</a> into step 16 of the
<a href="#create-term-definition">Create Term Definition algorithm</a>,
to make the control flow clearer and homogeneous with the rest of the specification.
This is in response to <a href="https://github.com/w3c/json-ld-api/issues/241">Issue 241</a>.</li>
<li>Clarified step <a href="#ctd-container">21.1</a> of the
<a href="#create-term-definition">Create Term Definition algorithm</a>
Expand Down