Improve fix to #241 #266
Improve fix to #241 #266
Conversation
the rest of substep 16.1 were merely a note, so I kept it as a formal note in step 16
|
Forgot to mention: the first commit in this PR is fixing a plain typo. So it should be retained even if we don't keep this PR. |
| <li>If <var>value</var> contains the <a>entry</a> <code>@id</code> and its value | ||
| does not equal <var>term</var>: | ||
| <li class="changed">If <var>value</var> contains the <a>entry</a> <code>@id</code> and its value | ||
| neither equals <var>term</var> nor is <code>null</code> |
There was a problem hiding this comment.
Maybe this should end with a ":"? Otherwise it runs into the inline "note" below. It'll look odd either way.
Related is that all the other inline "notes" also look odd compared to the full "NOTE" blocks. Were they supposed to be inline?
There was a problem hiding this comment.
ReSpec supports both, and sometimes it makes sense to do. Full block notes are pretty heavyweight.
There was a problem hiding this comment.
I think this still needs something done. It reads "... nor is null If null, the term ...". The inline note style is there for the "If null...", but the final rendered result could be improved.
Building on @gkellogg's PR #247 to address issue #241, I made a further change that's hopefuly not too disruptive, and should address @kasei's comment.
Preview | Diff