[css-sizing-4] Add responsively-sized iframes #13099
Merged
+90
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiishi
force-pushed
the
responsive-iframe
branch
2 times, most recently
from
187a8a2 to
b472ec5
Compare
chrishtr
reviewed
Nov 17, 2025
kojiishi
force-pushed
the
responsive-iframe
branch
2 times, most recently
from
851052d to
1d6d644
Compare
Based on the resolutions at: w3c#1771 (comment)
kojiishi
force-pushed
the
responsive-iframe
branch
from
1d6d644 to
033a922
Compare
tabatkins
reviewed
Nov 25, 2025
* Did an editorial rewrite of the "responsively-sized iframes" section; should be zero normative changes. * Rejiggered the syntax of the properties a little, integrating it better with the existing syntax, so that 'from-element' works the same as 'auto' (being a magic source of intrinsic size) and requiring a fallback size to be specified.
Member
|
I did some rejiggering of the text, Koji; please let me know if that's okay. It's mostly editorial, the only real change is that I integrated the grammar of the new value into the existing grammar better. Now you specify I also moved the statement about the value applying to iframes regardless of Otherwise, the edits are just reworking the text (including rearranging some existing text), and defining a specific term to hook into ("internal layout intrinsic size"). |
Contributor
Author
|
Thank you @tabatkins, it looks great to me. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 26, 2025
…[0,∞]>` This patch updates the `from-element` syntax from an optional `<length [0,∞]>` to a required `none | <length [0,∞]>`, to reflect the review of the spec PR[1]. [1] w3c/csswg-drafts#13099 Bug: 418397278 Change-Id: Ifccbd3a3cd551e47ef16b1585b3859e328946b34
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 26, 2025
…[0,∞]>` This patch updates the `from-element` syntax from an optional `<length [0,∞]>` to a required `none | <length [0,∞]>`, to reflect the review of the spec PR[1]. [1] w3c/csswg-drafts#13099 Bug: 418397278 Change-Id: Ifccbd3a3cd551e47ef16b1585b3859e328946b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206966 Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1550347}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 26, 2025
…[0,∞]>` This patch updates the `from-element` syntax from an optional `<length [0,∞]>` to a required `none | <length [0,∞]>`, to reflect the review of the spec PR[1]. [1] w3c/csswg-drafts#13099 Bug: 418397278 Change-Id: Ifccbd3a3cd551e47ef16b1585b3859e328946b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206966 Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1550347}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 26, 2025
…[0,∞]>` This patch updates the `from-element` syntax from an optional `<length [0,∞]>` to a required `none | <length [0,∞]>`, to reflect the review of the spec PR[1]. [1] w3c/csswg-drafts#13099 Bug: 418397278 Change-Id: Ifccbd3a3cd551e47ef16b1585b3859e328946b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206966 Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1550347}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the resolutions at:
#1771 (comment)