"if client is an environment" is always true

[isonmad]

4ce01b5#diff-27b79860afe28f01aed4f1f6228367faR1278 added if-else steps in several places in the wrong order, where it probably meant to be checking if client is the more specific category (an environment settings object) first, like 8b483b0#diff-27b79860afe28f01aed4f1f6228367faR3533 did -- because "if client is an environment" is always true regardless.

[jungkees]

Note that 4ce01b5#diff-27b79860afe28f01aed4f1f6228367faR1278 is different from "if client is an environment". It checks the type of the concept as "If client is a type of environment".

[isonmad]

What's the practical difference, exactly? Don't those mean the same thing here?

[annevk]

I tend to agree with @isonmad. E.g., we use something like "if X is an element" fairly often in DOM and it needs to be true even if X is a subclass of Element. At some point we'll formalize this through brands: whatwg/webidl#97.