Change label to encoding for FileReader.readAsText #106
Conversation
index.bs
Outdated
| @@ -1136,11 +1136,11 @@ the user agent must run the steps below. | |||
| The {{FileReader/readAsText()}} method</h5> | |||
|
|
|||
| The {{FileReader/readAsText()}} method can be called with an optional parameter, | |||
| <dfn argument for="FileReader/readAsText(blob, label), FileReader/readAsText(), FileReaderSync/readAsText(blob, label)" id="dfn-label">label</dfn>, | |||
| <dfn argument for="FileReader/readAsText(blob, encoding), FileReader/readAsText(), FileReaderSync/readAsText(blob, encoding)" id="dfn-encoding">encoding</dfn>, | |||
There was a problem hiding this comment.
I'd somewhat prefer it if we kept the IDs unchanged or at least kept the old IDs working.
There was a problem hiding this comment.
I can add the legacy reference too. Is there a precedent for keeping legacy links that I can follow in terms of documenting the reasoning, or possibly a Bikeshed tooling support for adding the legacy reference?
If not, I propose to add this line above:
<a id="dfn-label"><!-- Legacy anchor for when argument name was "label" --></a>There was a problem hiding this comment.
oldids as attribute should work, but I'm not sure it's worth changing this at all. I guess the editor can decide.
There was a problem hiding this comment.
Ah neat! I'll just add that in then since the support already exists. If for any reason (but I don't see one) it should be removed I don't mind removing it again.
Along with FileReaderSync, of course.
Before:
readAsText(blob[, label])
After:
readAsText(blob[, encoding])
|
Marked as non substantive for IPR from ash-nazg. |
Along with
FileReaderSync, of course.Before:
After:
(I have not run the bikeshedding tool to regenerate
index.htmlas I'm not sure how to.)Fixes #105