Skip to content

Commit 26f4302

Browse files
blixtmkruisselbrink
authored andcommitted
Change label to encoding for FileReader.readAsText (#106)
* Change label to encoding for FileReader.readAsText Along with FileReaderSync, of course. Before: readAsText(blob[, label]) After: readAsText(blob[, encoding]) * Add oldids="label" to support old links to encoding
1 parent e3f18d6 commit 26f4302

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

index.bs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ interface FileReader: EventTarget {
953953
// async read methods
954954
void readAsArrayBuffer(Blob blob);
955955
void readAsBinaryString(Blob blob);
956-
void readAsText(Blob blob, optional DOMString label);
956+
void readAsText(Blob blob, optional DOMString encoding);
957957
void readAsDataURL(Blob blob);
958958

959959
void abort();
@@ -1137,11 +1137,11 @@ the user agent must run the steps below.
11371137
The {{FileReader/readAsText()}} method</h5>
11381138

11391139
The {{FileReader/readAsText()}} method can be called with an optional parameter,
1140-
<dfn argument for="FileReader/readAsText(blob, label), FileReader/readAsText(), FileReaderSync/readAsText(blob, label)" id="dfn-label">label</dfn>,
1140+
<dfn argument for="FileReader/readAsText(blob, encoding), FileReader/readAsText(), FileReaderSync/readAsText(blob, encoding)" id="dfn-encoding" oldids="dfn-label">encoding</dfn>,
11411141
which is a {{DOMString}} argument that represents the label of an encoding [[!Encoding]];
11421142
if provided, it must be used as part of the <a>encoding determination</a> used when processing this method call.
11431143

1144-
When the <dfn method for=FileReader id="dfn-readAsText">readAsText(blob, label)</dfn> method is called,
1144+
When the <dfn method for=FileReader id="dfn-readAsText">readAsText(blob, encoding)</dfn> method is called,
11451145
the user agent must run the steps below.
11461146

11471147
1. If {{FileReader/readyState}} = {{FileReader/LOADING}} throw an {{InvalidStateError}} and <a>terminate this algorithm</a>.
@@ -1264,7 +1264,7 @@ take a {{Blob}} parameter.
12641264
This section defines this parameter.
12651265

12661266
<dl>
1267-
<dt><dfn id="dfn-fileBlob" argument for="FileReader/readAsArrayBuffer(blob), FileReader/readAsBinaryString(blob), FileReader/readAsText(blob, label), FileReader/readAsText(), FileReader/readAsDataURL(blob), URL/createObjectURL(blob), FileReaderSync/readAsArrayBuffer(blob), FileReaderSync/readAsBinaryString(blob), FileReaderSync/readAsText(blob, label), FileReaderSync/readAsDataURL(blob)">blob</dfn>
1267+
<dt><dfn id="dfn-fileBlob" argument for="FileReader/readAsArrayBuffer(blob), FileReader/readAsBinaryString(blob), FileReader/readAsText(blob, encoding), FileReader/readAsText(), FileReader/readAsDataURL(blob), URL/createObjectURL(blob), FileReaderSync/readAsArrayBuffer(blob), FileReaderSync/readAsBinaryString(blob), FileReaderSync/readAsText(blob, encoding), FileReaderSync/readAsDataURL(blob)">blob</dfn>
12681268
<dd>This is a {{Blob}} argument
12691269
and must be a reference to a single {{File}} in a {{FileList}}
12701270
or a {{Blob}} argument not obtained from the underlying OS file system.
@@ -1278,8 +1278,8 @@ When reading {{Blob}} objects using the {{FileReader/readAsText()}} <a>read meth
12781278
the following <dfn id="encoding-determination">encoding determination</dfn> steps must be followed:
12791279

12801280
1. Let |encoding| be null.
1281-
2. If the {{FileReader/readAsText()/label}} argument is present when calling the method,
1282-
set |encoding| to the result of the <a>getting an encoding</a> from {{FileReader/readAsText()/label}}.
1281+
2. If the {{FileReader/readAsText()/encoding}} argument is present when calling the method,
1282+
set |encoding| to the result of the <a>getting an encoding</a> from {{FileReader/readAsText()/encoding}}.
12831283
3. If the <a>getting an encoding</a> steps above return failure,
12841284
then set |encoding| to null.
12851285
4. If |encoding| is null,
@@ -1423,7 +1423,7 @@ interface FileReaderSync {
14231423

14241424
ArrayBuffer readAsArrayBuffer(Blob blob);
14251425
DOMString readAsBinaryString(Blob blob);
1426-
DOMString readAsText(Blob blob, optional DOMString label);
1426+
DOMString readAsText(Blob blob, optional DOMString encoding);
14271427
DOMString readAsDataURL(Blob blob);
14281428
};
14291429
</pre>
@@ -1440,7 +1440,7 @@ the {{FileReaderSync}} constructor must be available.
14401440
<h5 id="readAsTextSync">
14411441
The {{FileReaderSync/readAsText()}} method</h5>
14421442

1443-
When the <dfn method for=FileReaderSync id="dfn-readAsTextSync">readAsText(blob, label)</dfn> method is called,
1443+
When the <dfn method for=FileReaderSync id="dfn-readAsTextSync">readAsText(blob, encoding)</dfn> method is called,
14441444
the following steps must be followed:
14451445

14461446
1. Initiate a <a>read operation</a> using the <code>blob</code> argument,

0 commit comments

Comments
 (0)