Skip to content

Conversation

@Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 9073382079

Details

  • 0 of 29 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 41.028%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/client/src/components/AutoLink.ts 0 29 0.0%
Totals Coverage Status
Change from base Build 9066161611: -0.9%
Covered Lines: 689
Relevant Lines: 1717

💛 - Coveralls

@Mister-Hope
Copy link
Member Author

Mister-Hope commented May 14, 2024

See here https://github.com/vuejs/router/blob/8fbd9c427447a8e4a6ff486ae94224d040fb7b00/packages/router/src/RouterView.ts#L34 as an example

I strongly recommend preserving the prop interface, as extracting prop type from the component will cause issues in type declaration files.

@meteorlxy meteorlxy merged commit 8eb722f into main May 14, 2024
@meteorlxy meteorlxy deleted the auto-link branch May 14, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants