Skip to content

Add filtering of the mutations logging #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2017
Merged

Add filtering of the mutations logging #711

merged 2 commits into from
Apr 17, 2017

Conversation

Yamakaky
Copy link
Contributor

Fixes #710

ktsn
ktsn requested changes Mar 26, 2017
View reviewed changes
docs/en/plugins.md Outdated
@@ -102,6 +102,11 @@ The `createLogger` function takes a few options:
``` js
const logger = createLogger({
collapsed: false, // auto-expand logged mutations
filter(mutation, stateBefore, stateAfter) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space before the open parenthesis 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@Yamakaky
Copy link
Contributor Author

Anything missing before merge?

@ktsn ktsn requested a review from yyx990803 March 31, 2017 01:02
@ktsn
Copy link
Member

ktsn commented Mar 31, 2017

Waiting for the review by @yyx990803 🙂

@Yamakaky
Copy link
Contributor Author

OK

@Yamakaky
Copy link
Contributor Author

Do you have the time to do the review @yyx990803 ?

@yyx990803 yyx990803 merged commit 8029c39 into vuejs:dev Apr 17, 2017
@Yamakaky Yamakaky deleted the log-filter branch April 17, 2017 13:34
@Yamakaky
Copy link
Contributor Author

Cool! When do you think it will be released?

@ktsn ktsn mentioned this pull request Apr 18, 2017
Closed
@MachinisteWeb MachinisteWeb mentioned this pull request May 5, 2017
Open
@Yamakaky
Copy link
Contributor Author

Any release date idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yamakaky @ktsn @yyx990803