Update logger.js #588
Closed
Update logger.js #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add logger a new configurable param 'ignored', let programmer to decide to ignore some log he/she does not want to see.
ktsn
reviewed
Jan 17, 2017
| @@ -5,6 +5,7 @@ import { deepCopy } from '../util' | |||
| export default function createLogger ({ | |||
| collapsed = true, | |||
| transformer = state => state, | |||
| ignored = type => false, | |||
There was a problem hiding this comment.
It would be better to pass mutation object instead of type?
There was a problem hiding this comment.
Yeah, I think passing in the entire mutation object leaves room for more flexibility.
yyx990803
requested changes
Feb 6, 2017
| @@ -5,6 +5,7 @@ import { deepCopy } from '../util' | |||
| export default function createLogger ({ | |||
| collapsed = true, | |||
| transformer = state => state, | |||
| ignored = type => false, | |||
There was a problem hiding this comment.
Yeah, I think passing in the entire mutation object leaves room for more flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logger a new configurable param 'ignored', let programmer to decide to ignore some log he/she does not want to see.