Skip to content

fix($core): escape meta tags correctly (fix #2831) #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021
Merged

fix($core): escape meta tags correctly (fix #2831) #2832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/@vuepress/core/lib/client/root-mixins/updateMeta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import unionBy from 'lodash/unionBy'
import escape from 'escape-html'

export default {
// created will be called on both client and ssr
Expand Down Expand Up @@ -132,7 +133,7 @@ function renderPageMeta (meta) {
return meta.map(m => {
let res = `<meta`
Object.keys(m).forEach(key => {
res += ` ${key}="${m[key]}"`
res += ` ${key}="${escape(m[key])}"`
})
return res + `>`
}).join('\n ')
Expand Down