Skip to content

Conversation

BronsonQuick
Copy link
Contributor

@BronsonQuick BronsonQuick commented Sep 1, 2019

Summary

The Travis script is missing npm install which means Travis will show:

vuepress build docs
sh: 1: vuepress: not found

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BronsonQuick nice catch!

@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

As we saw with @kefranabg it's just for docs no need of package-lock my bad

@flozero flozero added topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@BronsonQuick BronsonQuick changed the title Add npm install fix: Add npm install Sep 6, 2019
Copy link

@adrianjost adrianjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think npm install is the default install script and you don't need to specify it.
https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#what-this-guide-covers

https://dev.to/hankchanocd/comment/5i5b

Nevertheless the install command should be placed in the install section of the Travis config.

install:
  - npm install
script:
  - npm run docs:build

Also keep in mind that npm ci might be a better solution: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#npm-ci-support

@flozero flozero merged commit 48162aa into vuejs:master Sep 8, 2019
@vue-bot
Copy link

vue-bot commented Sep 8, 2019

Hey @BronsonQuick, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@BronsonQuick BronsonQuick deleted the patch-1 branch September 8, 2019 08:16
@flozero
Copy link
Collaborator

flozero commented Sep 8, 2019

thank you all for the work. @adrianjost i agree with you we should iterate on your comment. Can you create a pr to update it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants