fix($core): do not transpile core packages' dependencies #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
added a commit
to vuejs/vue-cli
that referenced
this pull request
Aug 12, 2019
Need to stick to 1.0.2 until vuejs/vuepress#1771 is merged & released.
kefranabg
approved these changes
Aug 28, 2019
1 task
1 task
haoqunjiang
added a commit
to vuejs/vue-cli
that referenced
this pull request
Sep 6, 2019
The previous incompatibility issue was resolved: vuejs/vuepress#1771
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Didn't have the time to get a minimal reproduction, but here's the error log I've got after upgrading to vuepress 1.0.3: https://app.netlify.com/sites/vue-cli/deploys/5d51074c57e52800094f95af
Seems it's trying to transpile the core-js package and failed.
The change was added in #1685 and was trying to fix #1623. But I think adding the entry files of core plugins is enough to ensure babel's polyfill detection to work, so I excluded the nested
node_modulesdirectory in the path pattern.