Skip to content

add item updates to the todo-app example #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2016

Conversation

chrisvfritz
Copy link

Fixes #36.

@posva
Copy link
Member

posva commented Oct 13, 2016

Shouldn't we do ref.child().set() like this: https://jsfiddle.net/posva/wtyop5jy/ ?
update looks a bit dangerous for one field only, doesn't it?
I think you got it from the Samples in the docs (https://github.com/firebase/quickstart-js/blob/master/database/scripts/main.js)
@jwngr What are your thoughts on this? Should we show the set version on the example and add a link to the Reference doc (https://firebase.google.com/docs/reference/js/firebase.database.Reference)

@jwngr
Copy link

jwngr commented Oct 13, 2016

Yeah I would use set() on the deep child path instead of update() on the parent node.

@chrisvfritz
Copy link
Author

Thanks for the feedback! Updated.

@posva posva merged commit 7c3b835 into vuejs:master Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants