Skip to content

Support disabled attribute on select options #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2015
+8 −1
Merged

Support disabled attribute on select options #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/directives/model/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ function buildOptions (parent, options) {
} else {
el.text = op.text
el.value = op.value
if (op.disabled) {
el.disabled = true
}
}
} else {
el = document.createElement('optgroup')
Expand Down
6 changes: 5 additions & 1 deletion test/unit/specs/directives/model_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,19 +245,23 @@ if (_.inBrowser) {
data: {
test: 'b',
opts: [
{ text: 'Select an option', value: null, disabled: true },
{ text: 'A', value: 'a' },
{ text: 'B', value: 'b' }
]
},
template: '<select v-model="test" options="opts"></select>'
})
expect(el.firstChild.innerHTML).toBe(
'<option disabled="">Select an option</option>' +
'<option value="a">A</option>' +
'<option value="b">B</option>'
)
var opts = el.firstChild.options
expect(opts[0].disabled).toBe(true)
expect(opts[0].selected).toBe(false)
expect(opts[1].selected).toBe(true)
expect(opts[1].selected).toBe(false)
expect(opts[2].selected).toBe(true)
})

it('select + options + optgroup', function () {
Expand Down