Skip to content

Conversation

@madskonradsen
Copy link
Contributor

@madskonradsen madskonradsen commented Oct 28, 2017

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The existing test were passing due to the fact that the $off had a second argument. I have fixed the bug and introduced one more test to test the scenario where it doesn't make use of the second argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants