fix: ensure cleanup in watcher.get #5988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watcher.get should always clean up observee stack in order to prevent memory leak. Also, non-user defined watch should rethrow error. vuejs#5975
kazupon
approved these changes
Jun 28, 2017
posva
approved these changes
Jun 28, 2017
jskrzypek
pushed a commit
to jskrzypek/vue
that referenced
this pull request
Jul 6, 2017
watcher.get should always clean up observee stack in order to prevent memory leak. Also, non-user defined watch should rethrow error. fix vuejs#5975
jskrzypek
added a commit
to jskrzypek/vue
that referenced
this pull request
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watcher.get should always clean up observee stack in order to prevent memory leak. Also, non-user
defined watch should rethrow error.
#5975