-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
fix #5760: transition async component error #5796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f7dd9b to
2411c6f
Compare
|
It 's too late today and going to work tomorrow I will fill the unit test in tomorrow ... sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO 'div' is not a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is invisible, just a placeholder, used to replace comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @yyx990803
34f70dd to
e0e5dad
Compare
|
Now, I use a transition placeholder... can you help me to review it, thx : ) |
e0e5dad to
b2764bd
Compare
b2764bd to
072ac46
Compare
Kingwl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @gebilaoxiong for the hard work. I found out a simpler fix in c3cdfcf but your PR helped a lot in identifying the problem. |
|
Thanks, your code is pretty |
|
@yyx990803 there is a small problem c3cdfcf#diff-6964744ffd2d3536df0f526fb0e2c286R142 child.key = child.key == null
? id + child.tag
: isPrimitive(child.key)
? (String(child.key).indexOf(id) === 0 ? child.key : id + child.key)
: child.keyif child is then the child |

issue: #5760
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: