fix #5539: improve isDef type definition
#5549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export let warn = noop | ||
| export let tip = noop | ||
| export let formatComponentName | ||
| export let formatComponentName: Function = (null: any) // work around flow check |
Member
Author
There was a problem hiding this comment.
This cast is necessary because we cannot persuade flow that formatComponentName is initialized before other code.
| const props = {} | ||
| const propOptions = Ctor.options.props | ||
| if (isDef(propOptions)) { | ||
| propsData = propsData || {} |
Member
Author
There was a problem hiding this comment.
This is needed because propsData is possibly null.
Member
|
TIL about |
|
Also, doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
improve flow type coverage to make
isDefnarrow nullable value to no-null value.Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)Other information:
Currently
isDefcannot narrow nullable value, as tracked in facebook/flow#34. Howerver, we can use a special%checkscomment to instruct flow inline the function.To make this happen, we need first to type check
utl/index.js. So some type definition changes are required. I have tried my best to keep changes constrained to type level. But still some changes influence runtime.