upgrade flow type to 0.33 #3980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerringtonDarkholme
force-pushed
the
upgrade-flow
branch
from
db4624f to
71dce42
Compare
Member
|
Merged as part of #4007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading flow finds several typing issues (largely due to flow limitation) in compiler.
The first modification is to change
genDatato always returnstring, this requires extractingplainASTElement out.The second modification is to ensure
el.componentpresents when called withgenComponent. The checker does not flow type refinement information to function call. So we need a new parameter for the information.Remaining modifications are solely at type level.