Skip to content

Add undefined check for instance methods #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyx990803 merged 3 commits into from
Sep 11, 2016
Merged

Add undefined check for instance methods #3656

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
622e87c
add undefined check for instance methods
Sep 10, 2016
3cb17d4
added a warning for undefined methods
Sep 10, 2016
236fdc3
add production ENV check
Sep 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/instance/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ function initMethods (vm: Component) {
const methods = vm.$options.methods
if (methods) {
for (const key in methods) {
vm[key] = bind(methods[key], vm)
if (methods[key] != null) {
vm[key] = bind(methods[key], vm)
} else if (process.env.NODE_ENV !== 'production') {
warn(`The method ${key} on vue instance is undefined.`, vm)
Copy link
Member

@yyx990803 yyx990803 Sep 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add else if (process.env.NODE_ENV !== 'production') here so that the warning can be stripped?

Copy link
Contributor Author

@itsMapleLeaf itsMapleLeaf Sep 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link

@zzz6519003 zzz6519003 Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why do you provide vm as a second variable? it will log vm?

Copy link
Member

@LinusBorg LinusBorg Nov 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used to get the component name, if available:

https://github.com/vuejs/vue/blob/dev/src/core/util/debug.js#L10-L13

Copy link

@zzz6519003 zzz6519003 Nov 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I get it, You saved me!!!!!!!!!!

}
}
}
}
Expand Down