Skip to content

fix(vnode): support for browsers that do not support svg (fix #10248) #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(vnode): support for browsers that do not support svg (fix #10248) #10250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96cdbce
fix(vnode): support for browsers that do not support svg
Jul 9, 2019
2c4bad3
fix(patch): fix assigning a value to 'vnode.elm.style' has no effect
Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/core/vdom/patch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,17 @@ export function createPatchFunction (backend) {
: nodeOps.createElement(tag, vnode)
setScope(vnode)

// In some Android browsers that don't support SVG. The style attribute of the Element generated by createElementNS is null.
// `vnode.elm.style` is null.
// fix #10248
if (!vnode.elm.style) {
Object.defineProperty(vnode.elm, 'style', {
get: function () {
return Object.create(null)
}
})
}

/* istanbul ignore if */
if (__WEEX__) {
// in Weex, the default insertion order is parent-first.
Expand Down