-
Notifications
You must be signed in to change notification settings - Fork 919
CSS modules #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS modules #422
Conversation
I assume this depends on vuejs/vue#4091 - should be included in 2.0.4 |
Add
For easier debugging. |
libraryTarget: 'commonjs2' | ||
}) | ||
}, function (code) { | ||
// http://stackoverflow.com/questions/17581830/load-node-js-module-from-string-in-memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's tricky here. Anyway better to test a webpack generated node module?
c552c22
to
2a0537b
Compare
@PowerfulPony |
Looking good. Pending 2.0.4 release of |
@@ -40,7 +40,7 @@ | |||
"source-map": "^0.5.6", | |||
"vue-hot-reload-api": "^2.0.1", | |||
"vue-style-loader": "^1.0.0", | |||
"vue-template-compiler": "^2.0.0-rc.3", | |||
"vue-template-compiler": "git://github.com/YiSiWang/vue-template-compiler.git#fc2ce58", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.0.4 released, we can change this now
This is out in 9.8.0! |
@yyx990803
2.x uses
vue-template-compiler
, which doesn't expose non standard props (module
) on<style>
tag.Should we use
data-module
instead or modifyvue-template-compiler
to expose non standard props?I prefer the later cause
scoped
was removed from standard.