Skip to content

fix: process render function, exported as default #332 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2021
Merged

fix: process render function, exported as default #332 #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11436b
fix: process render function, exported as default
0x009922 May 6, 2021
200c871
Merge branch 'next' of https://github.com/vuejs/vue-jest into next
0x009922 May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions e2e/__projects__/basic/components/FunctionalRenderFn.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<script>
import { h } from 'vue'

export default () =>
h(
'div',
{
id: 'functional-render-fn'
},
'Nyan'
)
</script>
9 changes: 9 additions & 0 deletions e2e/__projects__/basic/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import NoScript from './components/NoScript.vue'
import PugRelative from './components/PugRelativeExtends.vue'
import { randomExport } from './components/NamedExport.vue'
import ScriptSetup from './components/ScriptSetup.vue'
import FunctionalRenderFn from './components/FunctionalRenderFn.vue'

// TODO: JSX for Vue 3? TSX?
import Jsx from './components/Jsx.vue'
Expand Down Expand Up @@ -179,3 +180,11 @@ xtest('processes .vue file using jsx', () => {
mount(Jsx)
expect(document.querySelector('#jsx')).toBeTruthy()
})

test('processes functional component exported as function', () => {
mount(FunctionalRenderFn)

const elem = document.querySelector('#functional-render-fn')
expect(elem).toBeTruthy()
expect(elem.innerHTML).toBe('Nyan')
})
2 changes: 1 addition & 1 deletion lib/generate-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module.exports = function generateCode(
if (tempOutput.includes('exports.render = render;')) {
node.add(';exports.default = {...exports.default, render};')
} else {
node.add(';exports.default = {...exports.default};')
// node.add(';exports.default = {...exports.default};')
}

return node.toStringWithSourceMap({ file: filename })
Expand Down