fix(pwa): Replace closeTag parameter with voidTag for HtmlWebpackPlugin #6518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HtmlWebpackPlugin has a voidTag parameter that needs to be set to true so that both <link> and <meta> are treated as void elements (with no contents). The closeTag parameter doesn't exist. https://github.com/jantimon/html-webpack-plugin/blob/570f735c237d4a03a65622cfe64652431aca4132/typings.d.ts#L280 https://html.spec.whatwg.org/multipage/syntax.html#void-elements Signed-off-by: Thomas Citharel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HtmlWebpackPlugin has a
voidTagparameter that needs to be set to trueso that both
<link>and<meta>are treated as void elements (with nocontents). The
closeTagparameter doesn't exist anymore since HtmlWebpackPlugin 4.https://github.com/jantimon/html-webpack-plugin/blob/570f735c237d4a03a65622cfe64652431aca4132/typings.d.ts#L280
https://html.spec.whatwg.org/multipage/syntax.html#void-elements
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: