Skip to content

fix(generator): support npm package aliases ("@npm:" in version specifier) #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2021
Merged

fix(generator): support npm package aliases ("@npm:" in version specifier) #6304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@vue/cli/__tests__/Generator.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ test('api: extendPackage allow git, github, http, file version ranges', async ()
bad: 'mochajs/mocha#4727d357ea',
bac: 'http://asdf.com/asdf.tar.gz',
bae: 'file:../dyl',
bcd: 'npm:vue@^3.0.0',
'my-lib': 'https://bitbucket.org/user/my-lib.git#semver:^1.0.0'
}
})
Expand All @@ -182,6 +183,7 @@ test('api: extendPackage allow git, github, http, file version ranges', async ()
bad: 'mochajs/mocha#4727d357ea',
bac: 'http://asdf.com/asdf.tar.gz',
bae: 'file:../dyl',
bcd: 'npm:vue@^3.0.0',
'my-lib': 'https://bitbucket.org/user/my-lib.git#semver:^1.0.0'
}
})
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli/lib/util/mergeDeps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const isValidRange = range => {
const isValidGitHub = range.match(/^[^/]+\/[^/]+/) != null
const isValidURI =
range.match(
/^(?:file|git|git\+ssh|git\+http|git\+https|git\+file|https?):/
/^(?:file|git|npm|git\+ssh|git\+http|git\+https|git\+file|https?):/
) != null

return isValidSemver || isValidGitHub || isValidURI
Expand Down