Skip to content

fix: ensure Dev Tool is enabled in Vue 3 runtime #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2020
Merged

fix: ensure Dev Tool is enabled in Vue 3 runtime #5788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fae132a
fix: ensure Dev Tool is enabled in Vue 3 runtime
haoqunjiang Aug 14, 2020
eec5407
test: use evaluate function instead of strings
haoqunjiang Aug 14, 2020
f63c929
test: only test vue 3
haoqunjiang Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@vue/cli-service/__tests__/serveVue3.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ test('serve with Vue 3', async () => {
async ({ page, nextUpdate, helpers }) => {
const msg = `Welcome to Your Vue.js App`
expect(await helpers.getText('h1')).toMatch(msg)
expect(await page.evaluate(() => window.__VUE__)).toBeDefined()

// test hot reload
const file = await project.read(`src/App.vue`)
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-service/lib/config/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ module.exports = (api, options) => {
'vue$',
options.runtimeCompiler
? 'vue/dist/vue.esm-bundler.js'
: '@vue/runtime-dom'
: 'vue/dist/vue.runtime.esm-bundler.js'
)

webpackConfig.module
Expand Down