Skip to content

change compiler option "jsx"; #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018
Merged

change compiler option "jsx"; #216

merged 1 commit into from
Jan 15, 2018

Conversation

SoraYama
Copy link
Contributor

Hello, this pr resolves a bug caused by compiler option "jsx" which compiles file incorrectly. "react" option compiles to .js file using React.createElement() which does not work in some cases (e.g. cannot pass Prop from parent VNode correctly in jsx tag.). A better way is using "preserve" option compile .tsx to .jsx and then use babel to transform.

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ktsn ktsn merged commit a415a17 into vuejs:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants