Skip to content

cache option for computed properties. #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Conversation

frandiox
Copy link
Contributor

I think the cache options works in Vue 2 but I could not find any information in the docs.
Is it just a documentation issue or was omitted on purpose for some reason? Thanks.

frandiox and others added 2 commits January 20, 2017 16:07
I think the `cache` options works in Vue 2 but I could not find any information in the docs.
Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a few tweaks and added info about pulling data into Vue's reactivity system, just to avoid people overusing cache: false.

@chrisvfritz
Copy link
Contributor

I'd like to get at least one more review on this before merging though.

@phanan
Copy link
Member

phanan commented Jan 20, 2017

LGTM.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
LGTM 👍

Sorry, my bad. when vue 2.0 docs wrote, i forget it ... 😭

@chrisvfritz chrisvfritz merged commit 6f56459 into vuejs:master Jan 24, 2017
@frandiox frandiox deleted the patch-1 branch January 24, 2017 11:15
dingyiming added a commit to volksbright/document-standard-vue that referenced this pull request Jan 24, 2017
* vuejs.org-master:
  `cache` option for computed properties. (vuejs#722)
  Update join.md (vuejs#725)

# Conflicts:
#	src/v2/api/index.md
#	src/v2/guide/join.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants