fix: Add "boolean" and "symbol" types for "key" attribute. #2614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Booleans as keys are supported since v2.4.2 and symbols since v2.5.12.
13 tasks
Member
|
Great update @mpawelski! Thanks for the in depth research and linking the to the resources which made the review much easier. Really appreciate it! 🙇🏽♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booleans as keys are supported since v2.4.2(commit) and symbols since v2.5.12(commit).
I created PR as suggested here. I think it now makes clear that this types are supported and not just "happens to work by accident".
I noticed that v-for has "since version" in type so I did the same.