Skip to content

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Apr 5, 2023

@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 9602b2c
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6430d1395f03ea0008f53231

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (1a3a28f) to head (9602b2c).
⚠️ Report is 541 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   90.86%   90.37%   -0.49%     
==========================================
  Files          24       24              
  Lines        1116     1195      +79     
  Branches      347      378      +31     
==========================================
+ Hits         1014     1080      +66     
- Misses         63       70       +7     
- Partials       39       45       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


Currently, all the docs can be found in `packages/docs`. It has a English version by default, and translation(s) in corresponding `<lang>` sub-folder(s):

- `zh`: Chinese translation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a link to the translation folder here as other translations might be hosted in a different repository. This will make more sense after adding an external translation

Jinjiang and others added 2 commits April 7, 2023 20:07
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks a lot!

@Jinjiang
Copy link
Member Author

Jinjiang commented Apr 8, 2023

@posva I missed the link to the zh folder. Here it is.

@Jinjiang Jinjiang merged commit 4b08a12 into main Apr 9, 2023
@Jinjiang Jinjiang deleted the jinjiang/translation-guide branch April 9, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants