-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: add translation guide into contributing.md #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vue-router canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 90.86% 90.37% -0.49%
==========================================
Files 24 24
Lines 1116 1195 +79
Branches 347 378 +31
==========================================
+ Hits 1014 1080 +66
- Misses 63 70 +7
- Partials 39 45 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/contributing.md
Outdated
|
||
Currently, all the docs can be found in `packages/docs`. It has a English version by default, and translation(s) in corresponding `<lang>` sub-folder(s): | ||
|
||
- `zh`: Chinese translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a link to the translation folder here as other translations might be hosted in a different repository. This will make more sense after adding an external translation
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks a lot!
@posva I missed the link to the zh folder. Here it is. |
Ref: #1770 (reply in thread)
Thanks.