query in `parseQuery` includes a leading `?`

[JammingBen]

Reproduction

https://github.com/JammingBen/vue-router-query-issue

Steps to reproduce the bug

• set up https://github.com/JammingBen/vue-router-query-issue
• run pnpm dev
• open http://localhost:5173 in the browser
• open the browser console
• add a query, e.g. http://localhost:5173/?foo=bar

Expected behavior

The query in https://github.com/JammingBen/vue-router-query-issue/blob/main/src/router/index.ts#L6 does not lead with a ?, so it should be e.g. foo=bar.

Actual behavior

The query leads with a ?: ?foo=bar.

Additional information

This only happens with the latest version v4.6.0. Possibly related to f89a842?

[posva]

This is indeed a mistake, it shouldn't contain the leading ?

[vBenTec]

Hey @posva,
first of all thanks for your fast effort to fix this.

We actually ran into a similar problem when we updated to vue-router 4.6.0, and I thought it might be related to this issue.

Today, we upgraded to 4.6.3, but the corresponding test is still failing. We’re passing the link /desktop/tickets/view? to our composable, and it returns the route with an unexpected trailing question mark:

New (4.6.0 - 4.6.3):

fullPath: '/tickets/view?'

Before (previous version 4.5.1):

fullPath: '/tickets/view'

So the optional question mark is now included in the fullPath, which breaks our test and potentially affects navigation.

We have the route configured as:

{
  path: '/tickets/view/:overviewLink?',
  name: 'TicketOverview',
  component: () => import(...),
  props: true,
  meta: { ... },
}

We’re using useLink from vue-router and passing the link index like this:

const { route } = useLink({ to: '/desktop/tickets/view?' })

It seems like the fullPath normalisation changed between versions perhaps related to optional params or trailing query markers.

Is this an intentional change, or a regression introduced in the recent versions?
Should I open a new report?

[posva]

It shouldn’t affect behavior. You should be able to remove the unneeded trailing slash