Skip to content

Fix: multiline-html-element-content-newline case sensitivity #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsnik merged 2 commits into from
Nov 18, 2018
Merged

Fix: multiline-html-element-content-newline case sensitivity #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae685b3
Fix: multiline-html-element-content-newline case sensitivity
armano2 Nov 14, 2018
961e110
fix typo in tests
armano2 Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/rules/multiline-html-element-content-newline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
// ------------------------------------------------------------------------------

const utils = require('../utils')
const casing = require('../utils/casing')

// ------------------------------------------------------------------------------
// Helpers
Expand All @@ -20,7 +21,7 @@ function isMultilineElement (element) {

function parseOptions (options) {
return Object.assign({
'ignores': ['pre', 'textarea']
ignores: ['pre', 'textarea']
}, options)
}

Expand Down Expand Up @@ -80,12 +81,18 @@ module.exports = {

let inIgnoreElement

function isIgnoredElement (node) {
return ignores.includes(node.name) ||
ignores.includes(casing.pascalCase(node.rawName)) ||
ignores.includes(casing.kebabCase(node.rawName))
}

return utils.defineTemplateBodyVisitor(context, {
'VElement' (node) {
if (inIgnoreElement) {
return
}
if (ignores.indexOf(node.name) >= 0) {
if (isIgnoredElement(node)) {
// ignore element name
inIgnoreElement = node
return
Expand Down Expand Up @@ -114,7 +121,7 @@ module.exports = {
},
messageId: 'unexpectedAfterClosingBracket',
data: {
name: node.name,
name: node.rawName,
actual: getPhrase(beforeLineBreaks)
},
fix (fixer) {
Expand Down
34 changes: 33 additions & 1 deletion tests/lib/rules/multiline-html-element-content-newline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,45 @@ tester.run('multiline-html-element-content-newline', rule, {
>content</ignore-tag>
<ignore-tag><div
>content</div></ignore-tag>
<ignore-tag>>content
<ignore-tag>content
content</ignore-tag>
</template>`,
options: [{
ignores: ['ignore-tag']
}]
},
{
code: `
<template>
<IgnoreTag>content</IgnoreTag>
<IgnoreTag
id="test-pre"
>content</IgnoreTag>
<IgnoreTag><div
>content</div></IgnoreTag>
<IgnoreTag>content
content</IgnoreTag>
</template>`,
options: [{
ignores: ['IgnoreTag']
}]
},
{
code: `
<template>
<ignore-tag>content</ignore-tag>
<ignore-tag
id="test-pre"
>content</ignore-tag>
<ignore-tag><div
>content</div></ignore-tag>
<ignore-tag>content
content</ignore-tag>
</template>`,
options: [{
ignores: ['IgnoreTag']
}]
},
// Ignore if no closing brackets
`
<template>
Expand Down