Skip to content

[Fixes #240] Fix valid-v-model rule #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2017
Merged

[Fixes #240] Fix valid-v-model rule #243

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ef95e
Omit BinaryExpression in v-model references check
michalsnik Nov 23, 2017
ab97736
Merge branch 'master' into fix-valid-v-model-rule
michalsnik Nov 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/valid-v-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function create (context) {

for (const reference of node.value.references) {
const id = reference.id
if (id.parent.type === 'MemberExpression') {
if (id.parent.type === 'MemberExpression' || id.parent.type === 'BinaryExpression') {
continue
}

Expand Down
8 changes: 8 additions & 0 deletions tests/lib/rules/valid-v-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ tester.run('valid-v-model', rule, {
{
filename: 'test.vue',
code: '<template><div><div v-for="x in list"><input v-model="x.foo"></div></div></template>'
},
{
filename: 'test.vue',
code: '<template><div><div v-for="x in list"><input v-model="foo[x]"></div></div></template>'
},
{
filename: 'test.vue',
code: '<template><div><div v-for="x in list"><input v-model="foo[x - 1]"></div></div></template>'
}
],
invalid: [
Expand Down