Skip to content

Fix false positives for script setup with ts literal type in vue/require-valid-default-prop #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2022
Merged

Fix false positives for script setup with ts literal type in vue/require-valid-default-prop #1854

merged 4 commits into from
Apr 20, 2022

Conversation

ota-meshi
Copy link
Member

fixes #1853

@ota-meshi ota-meshi requested a review from FloEdelmann April 19, 2022 10:34
FloEdelmann
FloEdelmann approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@ota-meshi ota-meshi added the bug label Apr 19, 2022
@ota-meshi ota-meshi merged commit 62e2620 into master Apr 20, 2022
@ota-meshi ota-meshi deleted the issue1853 branch April 20, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/require-valid-default-prop false-positive when using TS prop definition
2 participants
@ota-meshi @FloEdelmann