Skip to content

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Mar 21, 2022

Close #1797 .

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks really nice! I've commented a few small suggestions.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Thanks!

@FloEdelmann FloEdelmann requested a review from ota-meshi March 22, 2022 14:04
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit f5f4f97 into vuejs:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: vue/prefer-prop-type-boolean-first
3 participants